Fix CI #154
Merged
Fix CI #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windows-2019 images are discontinued, switch to '-latest'.
Need newer node-gyp to support newer Visual Studio versions. (Node-gyp 9 is the newest node-gyp that is compatible with NodeJS 14. It's new enough to support the Visual Studio version used in CI, though.)
macos-latest resolves to macos-15, which is too new to work with one of our dependencies. Specifically: there are compilation errors in git-utils --> libgit2 --> zlib when compiling with too new of an Xcode toolchain, apparently. So, pin to the macos-14 image, which still works with our dependencies.
savetheclocktower
approved these changes
Oct 18, 2025
Contributor
savetheclocktower
left a comment
savetheclocktower
left a comment
There was a problem hiding this comment.
Looks like CI to me. Looks good to me!
Member
Author
|
Thanx 🫡 It's mergin' time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details.
Makes CI pass.