Skip to content

fix(azure): add new way to auth against App Insight #7763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

puchy22
Copy link
Member

@puchy22 puchy22 commented May 16, 2025

Context

In check app_function_application_insights_enabled was missing the APPLICATIONINSIGHTS_CONNECTION_STRING to connect Application functions and App Insights.

Fix #7298

Description

  • Check the APPLICATIONINSIGHTS_CONNECTION_STRING configuration
  • Remove the check if the AppInishgt exists in same subscription due to false positives
  • Remove all related with AppInishgt service in tests

Checklist

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

and remove the check if the AppInishgt exists
@puchy22 puchy22 requested review from a team as code owners May 16, 2025 10:54
@github-actions github-actions bot added the provider/azure Issues/PRs related with the Azure provider label May 16, 2025
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.31%. Comparing base (f254a4b) to head (0df5985).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7763      +/-   ##
==========================================
- Coverage   81.31%   81.31%   -0.01%     
==========================================
  Files         258      258              
  Lines        9269     9268       -1     
==========================================
- Hits         7537     7536       -1     
  Misses       1732     1732              
Flag Coverage Δ
prowler 81.31% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 81.31% <ø> (-0.01%) ⬇️
api ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@puchy22 puchy22 added no-merge Please, DO NOT MERGE this PR. and removed no-merge Please, DO NOT MERGE this PR. labels May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/azure Issues/PRs related with the Azure provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app_function_application_insights_enabled bug resulting in false positives
1 participant