Skip to content

Conversation

@colan-dremio
Copy link

Several existing helpers are currently package private and would be helpful to expose for re-use in other packages.

Several existing helpers are currently package private and would be
helpful to expose for re-use in other packages.
@CLAassistant
Copy link

CLAassistant commented Nov 29, 2023

CLA assistant check
All committers have signed the CLA.

@colan-dremio
Copy link
Author

At present, this represents a set of classes/methods that I am explicitly planning to use. It leaves a few classes in a state that is partially public and partially package private. If there is interest, I'm happy to make more items public for consistency and reuse elsewhere too.

Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changed classes are all in the internal package of the test extension, those were not intended to be used externally.

Can you elaborate which functionality is missing and maybe have a PR that add the potentially missing functionality to the JUnit extension rather than relying on internal behavior of the test extension?

@colan-dremio
Copy link
Author

The primary use case was to support more than one MultiEnvTestExtension. I've created #7816 as a more robust solution.

@colan-dremio colan-dremio deleted the multienv-internals branch May 14, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants