Fix #7490: Replace cert-manager dependency in e2e tests#7511
Open
ShivamJha2436 wants to merge 1 commit intoprojectcontour:mainfrom
Open
Fix #7490: Replace cert-manager dependency in e2e tests#7511ShivamJha2436 wants to merge 1 commit intoprojectcontour:mainfrom
ShivamJha2436 wants to merge 1 commit intoprojectcontour:mainfrom
Conversation
Signed-off-by: ShivamJha2436 <shivamkumar87148@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7511 +/- ##
=======================================
Coverage 81.84% 81.84%
=======================================
Files 130 130
Lines 15722 15722
=======================================
Hits 12868 12868
Misses 2571 2571
Partials 283 283 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes the dependency on cert-manager in the e2e test suite and replaces it with a lightweight in-process certificate generation helper.
Previously, the e2e suite relied on cert-manager CRDs to generate test certificates. Although cert-manager was only used for testing, it was included in go.mod, causing its transitive dependencies (notably gateway-api) to affect Contour’s build.
When cert-manager updated its gateway-api dependency to a newer version, it introduced version conflicts with Contour’s own Gateway API usage, resulting in compilation failures.
What this PR does
Introduces a local certificate helper (
test/e2e/certs.go) that:kubernetes.io/tls) directlyRefactors e2e tests to use the new helper via the shared framework
Removes cert-manager usage from e2e tests
Removes cert-manager dependency from
go.modRemoves cert-manager installation from
test/scripts/make-kind-cluster.shUpdates
test/scripts/README.mdto reflect the new test flowWhy this change
Behavior parity
The new helper preserves key behaviors previously provided by cert-manager:
Testing
Related Issue
Fixes #7490