Support specifying --concurrency Envoy flag#7499
Open
msanft wants to merge 2 commits intoprojectcontour:mainfrom
Open
Support specifying --concurrency Envoy flag#7499msanft wants to merge 2 commits intoprojectcontour:mainfrom
--concurrency Envoy flag#7499msanft wants to merge 2 commits intoprojectcontour:mainfrom
Conversation
msanft
requested review from
sunjayBhatia and
tsaarni
and removed request for
a team
tsaarni
added
the
release-note/small
On machines with high core count, not setting the `--concurrency` flag of Envoy results in Envoy defaulting to having as many worker threads as HW threads. In low-load scenarios, this creates very high CPU and memory usage unnecessarily. This fixes the issue by adding a concurrency flag and plumbing it through the `ContourDeployment` CRD. Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>
Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>
msanft
force-pushed
the
msanft/concurrency
branch
from
eae69f2 to
627def9
Compare
|
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
github-actions
Bot
added
the
lifecycle/stale
Author
|
Not stale |
github-actions
Bot
removed
the
lifecycle/stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On machines with high core count, not setting the
--concurrencyflag of Envoy results in Envoy defaulting to having as many worker threads as HW threads. In low-load scenarios, this creates very high CPU and memory usage unnecessarily. This fixes the issue by adding a concurrency flag and plumbing it through theContourDeploymentCRD.224-thread machine without the fix:
after the fix (
concurrency: 4):