feat: add LoadBalancerSourceRanges and LoadBalancerClass#7433
Open
MayorFaj wants to merge 1 commit intoprojectcontour:mainfrom
Open
feat: add LoadBalancerSourceRanges and LoadBalancerClass#7433MayorFaj wants to merge 1 commit intoprojectcontour:mainfrom
MayorFaj wants to merge 1 commit intoprojectcontour:mainfrom
Conversation
…blishing Signed-off-by: MayorFaj <mayorfaj@gmail.com>
|
Hi @MayorFaj! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace |
Author
|
@tsaarni , when ever you get the chance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7334
What this PR does / why we need it
The Contour Gateway Provisioner had no way to configure two standard
Kubernetes Service fields on the provisioned Envoy Service:
spec.loadBalancerSourceRanges— restricts inbound traffic to specificclient CIDRs at the load balancer level
spec.loadBalancerClass— selects a specific load balancer implementationThis PR exposes both fields through
ContourDeployment.spec.envoy.networkPublishing,following the same pattern used by existing fields (
externalTrafficPolicy,ipFamilyPolicy,serviceAnnotations).Changes
API
loadBalancerSourceRanges []stringandloadBalancerClass *stringto the
NetworkPublishingstruct inContourDeploymentProvisioner
EnvoyNetworkPublishingin the internal modelDesiredEnvoyServiceapplies both fields, guarded inside theLoadBalancerServicecase only (they have no meaning for NodePort or ClusterIP)LoadBalancerServiceChangedtracks drift for both fieldsTests
TestDesiredEnvoyService— asserts fields are set forLoadBalancerServiceand absent for
NodePortServiceTestLoadBalancerServiceChanged— three new cases covering changed sourceranges, unchanged (equal non-empty) source ranges, and changed class
ContourDeploymentparams to Service spec
Docs
loadBalancerClasstosite/content/docs/main/config/gateway-api.md