fix(app): configOf redacts secret defaults + datahub-port artifacts#47
Open
wmadden-electric wants to merge 4 commits into
Open
fix(app): configOf redacts secret defaults + datahub-port artifacts#47wmadden-electric wants to merge 4 commits into
wmadden-electric wants to merge 4 commits into
Conversation
configOf promises 'secrets marked, values absent', but reported param.default unredacted. With deployer-env-sourced secret values riding in as defaults (the datahub port's secrets bridge), that leaks the value into introspection. Report default: undefined for any secret param, service-own or input. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
…port evidence recorded Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
@prisma/alchemy
@prisma/app
@prisma/app-assemble
@prisma/app-cli
@prisma/app-cloud
@prisma/app-nextjs
@prisma/app-node
@prisma/app-rpc
prisma-app
commit: |
Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #45 (base:
claude/cron-driver-system). The framework-side companion to the datahub port (prisma/datahub#2, TML-3012).configOf.configOfpromises "secrets marked, values absent" but reportedparam.defaultunredacted. The datahub port sources secret values from the deployer's env as defaults, which turned this from theoretical into a real leak. Nowdefault: undefinedfor any secret param, service-own or input. Guarded by a test.🤖 Generated with Claude Code