Fix for [BUG] Error handling timezones #305 #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Ferdman <[email protected]>
Update minmax operator image
fix: check if update_data contains update before batch_update
Drop duplicate sentence in CONTRIBUTING.md
mhangaard
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Does this PR also handle switches to daylight savings time (DST)?
The DST problem is addressed in a reply to the bug report: #305 (comment)
If the DST problem is to be addressed, a test case could be
x = pd.date_range('2024-09-27 17:00:00', '2024-12-11 16:00:00', tz="US/Pacific")
relayout_data = {'xaxis.range[0]': '2024-09-27T17:00:00-07:00', 'xaxis.range[1]': '2024-12-12T15:59:00-08:00'}
or
relayout_data = {'xaxis.range[0]': Timestamp('2024-09-27 17:00:00-0700', tz='US/Pacific'), 'xaxis.range[1]': Timestamp('2024-12-12 15:59:00-0800', tz='US/Pacific')}
There was a problem hiding this comment.
I added a fix and a test for this issue in 5108824
* Parametrize test_utils.py on is_figure * 🔍 remove dtype parsing as orjon>3.10 supports float16 #118 * 💪 refactor: streamline JupyterDash integration and remove unused persistent inline logic * 💨 move construct_update_data_patch method into the FigureResampler class * 🐐 refactor: enhance test utilities and add support for Plotly>=6 data handling * 🙏 enhance serialization tests for plotly>6 * 📝 remove debug print statement and enhance type handling for hf_x * 🔒 update dependency versions in pyproject.toml to Support plotly 6 #334 * 🔍 drop python3.7 CI workflow and upgrade upload-artifact action * 🙏 fix pickling of figurewidget resampler * 🙏 fix tests * 💨 migration of code towards new upload artifact * 💪 enhance CI workflow to improve test result uploads and add retention settings * 🕳️ fix: ensure correct dtype handling for aggregated x indices in PlotlyAggregatorParser * ⬆️ chore: update dependency constraints for pandas and pyarrow in pyproject.toml * 🙈 fix linting * 🔍 fix: correct spelling in streamlit_app.py comments and update dash-extensions and pyarrow versions in requirements.txt * ⬆️ chore: update ipywidgets version constraint to allow for newer versions * 🚧 test: set random seed for reproducibility in test_wrap_aggregate * 🙈 chore: update ipywidgets version constraint for serialization support * 🙈 * 🔍 ci: conditionally skip tests on Python 3.12 for Ubuntu (as it keeps hanging in github actions) * 🔍 ci: exclude Python 3.12 on Ubuntu from test matrix to prevent hangs * 🖊️ review code * 🧹 cleanup comments --------- Co-authored-by: Maxim Ivanov <[email protected]> Co-authored-by: jeroen <[email protected]>
…esampler into bug/305_timezones
|
Ready for review @jvdd! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.