Rename Resources.Localisation.Web using directives to WebLocalisation#38198
Closed
diquoks wants to merge 1 commit into
Closed
Rename Resources.Localisation.Web using directives to WebLocalisation#38198diquoks wants to merge 1 commit into
Resources.Localisation.Web using directives to WebLocalisation#38198diquoks wants to merge 1 commit into
Conversation
since after a month and a half problems with resolving name conflicts continued to appear, i thought that renaming in this way may be a better option than ppy#37675
Member
|
I'm not seeing what this fixes |
Contributor
Author
allows for fewer lines of code to resolve namespace conflicts, also making it easier to understand which localisation a string is coming from
|
peppy
self-requested a review
July 9, 2026 15:06
Member
|
Don't quite see the point. Also if this is to be applied, it should be enforced somehow, and also applied to the 100+ other cases. 
|
diquoks
deleted the
quick-fix/rename-web-localisation-using-directives-once-again
branch
July 9, 2026 15:12
Contributor
Author
okay, i accept your point of view |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since after a month and a half problems with resolving name conflicts continued to appear, i thought that renaming in this way may be a better option than #37675