Skip to content

Localise some strings on SecondFactorAuthForm #36961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peppy merged 1 commit into from
Mar 14, 2026
Merged

Localise some strings on SecondFactorAuthForm #36961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions osu.Game/Localisation/LoginPanelStrings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,16 @@ public static class LoginPanelStrings
/// </summary>
public static LocalisableString Register => new TranslatableString(getKey(@"register"), @"Register");

/// <summary>
/// "An email has been sent to you with a verification code. Enter the code."
/// </summary>
public static LocalisableString CodeSent => new TranslatableString(getKey(@"code_sent"), @"An email has been sent to you with a verification code. Enter the code.");

/// <summary>
/// "Enter code"
/// </summary>
public static LocalisableString EnterCode => new TranslatableString(getKey(@"enter_code"), @"Enter code");

private static string getKey(string key) => $@"{prefix}:{key}";
}
}
9 changes: 5 additions & 4 deletions osu.Game/Overlays/Login/SecondFactorAuthForm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
using osu.Game.Graphics;
using osu.Game.Graphics.Containers;
using osu.Game.Graphics.UserInterface;
using osu.Game.Localisation;
using osu.Game.Online.API;
using osu.Game.Online.API.Requests;
using osu.Game.Online.API.Requests.Responses;
Expand Down Expand Up @@ -104,12 +105,12 @@ private void showEmailVerification()
{
RelativeSizeAxes = Axes.X,
AutoSizeAxes = Axes.Y,
Text = "An email has been sent to you with a verification code. Enter the code.",
Text = LoginPanelStrings.CodeSent,
},
codeTextBox = new OsuTextBox
{
InputProperties = new TextInputProperties(TextInputType.Code),
PlaceholderText = "Enter code",
PlaceholderText = LoginPanelStrings.EnterCode,
Copy link
Copy Markdown
Contributor Author

@diquoks diquoks Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would really like to use UserVerificationStrings.BoxSent, but it will need to make a workaround for user's email

RelativeSizeAxes = Axes.X,
TabbableContentContainer = this,
},
Expand Down Expand Up @@ -169,12 +170,12 @@ private void showTotpVerification()
{
RelativeSizeAxes = Axes.X,
AutoSizeAxes = Axes.Y,
Text = "Please enter the code from your authenticator app.",
Text = UserVerificationStrings.BoxTotpHeading,
},
codeTextBox = new OsuNumberBox
{
InputProperties = new TextInputProperties(TextInputType.NumericalPassword),
PlaceholderText = "Enter code",
PlaceholderText = LoginPanelStrings.EnterCode,
RelativeSizeAxes = Axes.X,
TabbableContentContainer = this,
},
Expand Down
Loading