Fix song select navigation with page up/down #36293
Open
+85
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #36099
This PR fixes keyboard navigation in the beatmap select carousel for lazer by implementing page-wise traversal with the Page Up and Page Down keys and changing it from only scrolling to actually selecting items.
Changes:
TraversalType.Pagein the keyboard traversal switch.traverseKeyboardPage(int direction)method to move the selection by approximately one "page" of visible items, accounting for partially obscured items like the search bar.PageUp→ SelectPreviousPagePageDown→ SelectNextPageThe code may be very explicit for the scroll logic with the page keys, so I would appreciate some feedback when the PR is reviewed.
The naming of the keybinds may need to be adjusted.
Next pageandprevious pagemay be somewhat misleading.Behavior after the change:
See:
https://www.youtube.com/watch?v=JXmKAhhKiCc