-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add ability to mark skins as favourite in the "Current skin" settings dropdown #36260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hopefully you're running in debug, which means it won't touch your life database. Also not updating the schema version doesn't "nuke" anything; the game just won't start.
Let's not. Right click maybe, alt click no. |
Yes I was. Just didn't know whether my tests clearing the skins from realm in the debug instance matters to anyone
Well, the game started, and I got a realm error that made a backup of my then current realm and created a fresh one
That's pretty smart actually. That way the same "shortcut" can be brought to touch devices via the long-press to right click interaction |
For sure. But I also like your pull to action thing. Haven't considered the code yet though. |
|
Went ahead and changed the I think the drag motion as well as the long press can coexist just fine. Seems like a good thing to leave up to the user; they can decide how they want to add favourites themselves. And this makes it so that a "shortcut" isn't present just on desktop/devices with a keyboard connected.
2026-01-08.18-02-41.mp4 |
|
Went ahead and pushed the change so nobody has to wait for me when it's time to review everything |
First pr
What's included:
Current skindropdownRight clcikLong holdPreview:
2026-01-08.18-02-41.mp4
Some things I should probably mention:
schema_version, don't know if there is anything besides that which needs to be doneUseFreshStoragePerRun => true;was supposed to prevent that from happening. Unless I completely don't understand how to work itDrawableDropdownMenuItems. There are only 4 of them + the<Random Skin>so favourited skins would still appear high in the list.I think this is pretty much it