Skip to content

Conversation

@Redo7
Copy link

@Redo7 Redo7 commented Jan 7, 2026

First pr

What's included:

  • Skins can now be marked with a star (visible on hover, on the left of the skin's name) from within the Current skin dropdown
    • This pushes them to the top of the list, but right below the hard-coded default skins
    • The changes are only visible after re-opening the dropdown to prevent the dropdown from jumping to the top of the list which would be annoying when trying to manage large skin collections
  • There is also a shortcut which will mark a skin as favourite in the dropdown
    • Desktop: Right clcik
    • Touch devices: Long hold

Preview:

2026-01-08.18-02-41.mp4

Some things I should probably mention:

  • My realm got nuked because I didn't update the (now updated) schema_version, don't know if there is anything besides that which needs to be done
  • The visual test clears the realm and writes a few entries back into it. Don't know if this is a big issue. Thought setting UseFreshStoragePerRun => true; was supposed to prevent that from happening. Unless I completely don't understand how to work it
  • Default skins can not be marked as favourite
    • While it could be easily extended, I didn't really see much purpose in that, so they render as the regular DrawableDropdownMenuItems. There are only 4 of them + the <Random Skin> so favourited skins would still appear high in the list.

I think this is pretty much it

@peppy
Copy link
Member

peppy commented Jan 7, 2026

My realm got nuked because I didn't update the (now updated) schema_version, don't know if there is anything besides that which needs to be done

Hopefully you're running in debug, which means it won't touch your life database. Also not updating the schema version doesn't "nuke" anything; the game just won't start.

On desktop, it's also possible to mark skins as favourite by Alt + Clicking anywhere within the hovered skin

Let's not. Right click maybe, alt click no.

@Redo7
Copy link
Author

Redo7 commented Jan 7, 2026

Hopefully you're running in debug, which means it won't touch your life database.

Yes I was. Just didn't know whether my tests clearing the skins from realm in the debug instance matters to anyone

Also not updating the schema version doesn't "nuke" anything; the game just won't start.

Well, the game started, and I got a realm error that made a backup of my then current realm and created a fresh one

On desktop, it's also possible to mark skins as favourite by Alt + Clicking anywhere within the hovered skin
Let's not. Right click maybe, alt click no.

That's pretty smart actually. That way the same "shortcut" can be brought to touch devices via the long-press to right click interaction

@peppy
Copy link
Member

peppy commented Jan 8, 2026

That's pretty smart actually. That way the same "shortcut" can be brought to touch devices via the long-press to right click interaction

For sure. But I also like your pull to action thing. Haven't considered the code yet though.

@Redo7
Copy link
Author

Redo7 commented Jan 8, 2026

Went ahead and changed the Alt + Click to just the right mouse button. Also made sure it works on touch devices via the right click from long touch.

I think the drag motion as well as the long press can coexist just fine. Seems like a good thing to leave up to the user; they can decide how they want to add favourites themselves. And this makes it so that a "shortcut" isn't present just on desktop/devices with a keyboard connected.

Haven't pushed those changes yet, but let me know if I should 👍 Those are now pushed

2026-01-08.18-02-41.mp4

@Redo7
Copy link
Author

Redo7 commented Jan 11, 2026

Went ahead and pushed the change so nobody has to wait for me when it's time to review everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants