Skip to content

Change toolbar buttons tooltips to be more visible#308

Merged
peppy merged 3 commits into
ppy:masterfrom
stanriders:fix-toolbar-tooltips
May 19, 2026
Merged

Change toolbar buttons tooltips to be more visible#308
peppy merged 3 commits into
ppy:masterfrom
stanriders:fix-toolbar-tooltips

Conversation

@stanriders

Copy link
Copy Markdown
Member

Before:
image
After:
image

Hover container in the PerformanceCalculatorSceneManager never really worked which made the buttons tooltip text annoying to read. This changes it to be based on normal tooltips logic instead
ScreenSelectionButton is now a slimmed down copy of the ToolbarButton now

@stanriders
stanriders requested a review from tsunyoku May 18, 2026 13:47
@stanriders stanriders added the perfcalc-gui PerformanceCalculatorGUI label May 18, 2026
Comment thread PerformanceCalculatorGUI/Components/ScreenSelectionButton.cs Fixed
Comment thread PerformanceCalculatorGUI/Components/ScreenSelectionButton.cs Fixed
Comment thread PerformanceCalculatorGUI/Components/ScreenSelectionButton.cs Fixed
Shadow = true,
Font = OsuFont.GetFont(size: 18, weight: FontWeight.Bold)
},
subTooltipFlow = new FillFlowContainer

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this hotkey stuff actually used in this project?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Settings can be opened using ctrl+o

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like a lot of faff to be inlining for one usage most people already know, dunno.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but I do want to add screen switching hotkeys at some point too and those definitely will need a tooltip

@peppy
peppy merged commit d82cf2a into ppy:master May 19, 2026
4 checks passed
@stanriders
stanriders deleted the fix-toolbar-tooltips branch July 5, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perfcalc-gui PerformanceCalculatorGUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants