Skip to content

Allow legacy score id for "populate from score"#269

Closed
Givikap120 wants to merge 3 commits into
ppy:masterfrom
Givikap120:allow-legacy-score-id
Closed

Allow legacy score id for "populate from score"#269
Givikap120 wants to merge 3 commits into
ppy:masterfrom
Givikap120:allow-legacy-score-id

Conversation

@Givikap120

Copy link
Copy Markdown
Contributor

It changes score input field to text so you can enter scores from legacy db

@stanriders stanriders left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very dirty implementation. You're lacking any kind of validation now, as well as making score id fields not actually contain score id

How useful is this? Legacy score links should not be exposed anywhere anymore I'm pretty sure, why would we need to support them?

@stanriders stanriders added the perfcalc-gui PerformanceCalculatorGUI label Jun 28, 2025
@Givikap120

Copy link
Copy Markdown
Contributor Author

This is a very dirty implementation. You're lacking any kind of validation now, as well as making score id fields not actually contain score id

How useful is this? Legacy score links should not be exposed anywhere anymore I'm pretty sure, why would we need to support them?

If you have legacy link (happens when you take score from lb without lazer mode) - you need to go through painful process of extracting new id from json response.
With this - you can just use legacy id, saving time.

@wulpine

wulpine commented Jun 29, 2025

Copy link
Copy Markdown
Member

If you have legacy link (happens when you take score from lb without lazer mode)

are you by any chance using osuplus? It replaces new links with the legacy ones

you need to go through painful process of extracting new id from json response

might help you save some time if the above is true—the "Download Replay" button always has the new score ID

@stanriders

Copy link
Copy Markdown
Member

This is a very dirty implementation. You're lacking any kind of validation now, as well as making score id fields not actually contain score id
How useful is this? Legacy score links should not be exposed anywhere anymore I'm pretty sure, why would we need to support them?

If you have legacy link (happens when you take score from lb without lazer mode) - you need to go through painful process of extracting new id from json response. With this - you can just use legacy id, saving time.

I just checked, both lazer and non-lazer modes use new links

@Givikap120

Copy link
Copy Markdown
Contributor Author

Added the validation

@stanriders

Copy link
Copy Markdown
Member

There are no legacy score links anywhere on the website anymore, and the old score ids are slowly being phased out completely - there's no use for this.
If you use osuplus enable lazer mode and it will stop redirecting you to legacy pages. Arguably the plugin developer should be switching to apiv2 at this point anyway

@stanriders stanriders closed this Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perfcalc-gui PerformanceCalculatorGUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants