Skip to content

Implements console font size (#4411) #8088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kylebutts
Copy link
Contributor

Release Notes

New Features

  • Add configuration settings to change the font of the Console. Previously, the editor font settings were used.

Bug Fixes

  • N/A

QA Notes

I tested this in a debug build of Positron

@juliasilge
Copy link
Contributor

Thank you so much for this PR, @kylebutts! We so appreciate your willingness to get into the details here 🙌

Currently the console font is based on the font from the editor and not the font from the terminal; the console itself is actually a teeny tiny editor! To implement #4411, we would want to create a parallel set of configuration options that match how the editor font is defaulted and configured, but for the console. Basing on the terminal font (and falling back to that) is not the approach we would want to take.

I'm sorry that we can't move forward with this PR, and again, I want to say a huge thank you for your contributions so far. We would be happy to review and accept a PR taking that alternative approach, although no rush on that because we are approaching when we will branch for our next release https://github.com/posit-dev/positron/milestone/23, which will be the first non-beta release for Positron! 🎉

If you were interested in contributing a different PR for this, we would be able to review it starting the week of June 30.

@kylebutts
Copy link
Contributor Author

I have pushed changes that use editor settings as default! No rush on this; good luck with the final push for non-beta release!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants