[Helm] Support extraSecrets in vector and datadog daemonsets#131
[Helm] Support extraSecrets in vector and datadog daemonsets#131nyergler wants to merge 5 commits into
Conversation
The vector and datadog daemonsets used individual secretKeyRef entries for DEPLOYMENT and DEPLOYMENT_KEY, so they couldn't access values stored in extraSecrets. Switch to envFrom (matching the pattern used by all other deployments) so these daemonsets pick up secrets from both the main config secret and any user-provided extraSecrets. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@erictg I'm not sure this is correct, would appreciate you giving it a once over. A deployment using a secret for their deployment key isn't sending logs, and I think this is the issue. |
erictg
left a comment
erictg
left a comment
There was a problem hiding this comment.
Looks good to me, sorry I missed that. I didn't think about those values needing to be passed into these daemonsets when I initially added extra secrets.
Before you merge (if you haven't already) just run helm lint to double check that it's valid.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Could you take another look at this, @erictg ? Checks seemed to think that |
erictg
left a comment
erictg
left a comment
There was a problem hiding this comment.
One question about the use of $(DEPLOYMENT).
To see what the rendered resource would look like, you can run helm template <release-name> <chart> -f values.yaml.
2 participants
The vector and datadog daemonsets used individual secretKeyRef entries for DEPLOYMENT and DEPLOYMENT_KEY, so they couldn't access values stored in extraSecrets. Switch to envFrom (matching the pattern used by all other deployments) so these daemonsets pick up secrets from both the main config secret and any user-provided extraSecrets.