Skip to content

refactor: Base the meta expressions on the DSL instead of the IR #22906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

coastalwhite
Copy link
Collaborator

This is part of working towards #22780.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels May 23, 2025
Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 40.33149% with 108 lines in your changes missing coverage. Please review.

Project coverage is 80.62%. Comparing base (5bff877) to head (c52a9d0).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/dsl/expr/mod.rs 31.25% 55 Missing ⚠️
crates/polars-plan/src/plans/ir/tree_format.rs 44.21% 53 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22906      +/-   ##
==========================================
- Coverage   80.67%   80.62%   -0.06%     
==========================================
  Files        1671     1672       +1     
  Lines      221284   222156     +872     
  Branches     2791     2798       +7     
==========================================
+ Hits       178525   179107     +582     
- Misses      42094    42383     +289     
- Partials      665      666       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ritchie46
Copy link
Member

For properties I think going through the IR is fine.

Is this refactor because of mutation and DSL -> IR -> DSL not being lossless mapping?

@coastalwhite
Copy link
Collaborator Author

coastalwhite commented May 23, 2025

For properties I think going through the IR is fine.

Is this refactor because of mutation and DSL -> IR -> DSL not being lossless mapping?

No, it is extracted from the DataTypeExpr PR. There we need to know the Schema for dsl expr -> ir expr. So we need to remove these instances. This is important in other instances as well, i.e. selectors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants