fix: Handle file:// URIs in scans by adding PythonScanSourceInput::Uri variant
#22767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt711
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
fix
2 tasks
| @@ -28,13 +28,20 @@ use crate::{PyDataFrame, PyExpr, PyLazyGroupBy}; | |||
| fn pyobject_to_first_path_and_scan_sources( | |||
| obj: PyObject, | |||
| ) -> PyResult<(Option<PathBuf>, ScanSources)> { | |||
| use crate::file::{PythonScanSourceInput, get_python_scan_source_input}; | |||
| use crate::file::{PythonScanSourceInput, get_python_scan_source_input, parse_file_uri}; | |||
There was a problem hiding this comment.
Can we try a simpler fix where we strip the file: prefix in this function if we see it?
|
I also just checked, we have similar issues with any cloud path - q = pl.scan_parquet("s3://bucket/file")
print(q._ldf.visit().view_current_node().paths)
[PosixPath('s3:/bucket/file')]A proper fix should probably be done in a generic manner over any |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
scan_parquet("file://...")converts URI to invalid Path #22766