refactor: middleware transform can take ownership #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
sunli829
force-pushed
the
master
branch
2 times, most recently
from
8f583de to
44a0067
Compare
|
@sunli829 any follow-up plan? |
sunli829
force-pushed
the
master
branch
9 times, most recently
from
b7798f9 to
d501357
Compare
sunli829
force-pushed
the
master
branch
4 times, most recently
from
1f79548 to
cf7780f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change. But since we always use
middleware.transformexactly once, take the ownership can reduce some unnecessary wrapper.For example, a middleware can take an owned value, but since
transformuse&self, when decorateendpoint, you can only pass a ref of that owned value, or copy, or Arc(Mutex).cc @sunli829 what do you think?