-
-
Notifications
You must be signed in to change notification settings - Fork 702
deprecate loadable util #3217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
deprecate loadable util #3217
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
Size Change: -343 B (-0.35%) Total Size: 98.5 kB
ℹ️ View Unchanged
|
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/93VVVJ7V6 |
See documentations for usage instructions.
|
|
||
| const LOADING: Loadable<unknown> = { state: 'loading' } | ||
|
|
||
| export function loadable<Value>(anAtom: Atom<Value>): Atom<Loadable<Value>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we deprecate loadable now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of doing it with another step, but yeah we can do that now. Let me try.
loadableis deprecated infavor ofunwrap.Userland implementation of loadable: