Conversation
Register the ReactTable loadable and add the @tanstack/react-table dependency, then add a DataTable component that lists the submissions stored by the form block, exports them to CSV and clears them. Column ordering, cell rendering and item selection live in pure helpers with vitest unit tests. Refs #16
Add a Show Form / Show Data toggle to the form block edit view that renders the DataTable when the block stores submissions. Refs #16
Extract the schema-field and record builders out of FormDataStore into utils/datamanager.py, add type hints and TypedDict definitions in types.py, cache the request block_id, and add a total_records_in_block helper. Cover the new helpers with unit tests. Refs #16
Drop the FormSerializer block serializer and its subscriber registrations; SchemaFormBlockSerializer already handles captcha props, attachments limit and default_ field stripping for schemaForm blocks.
sneridagh
approved these changes
Jun 18, 2026
sneridagh
left a comment
sneridagh
left a comment
Member
There was a problem hiding this comment.
Overall LGTM a few comments in the frontend side. I did not review the backend in depth though.
Base the addon's vitest config on @plone/volto's shared config (jsdom, plugins, projects) and layer the local @plone/volto-form-block source aliases and core fs.allow path on top, so component tests run with the same setup as core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds frontend support to manage the submissions stored by a form block's Store data action, plus the backend refactor that underpins it.
In the form block editor you can now toggle between Show Form and Show Data; the data view lists every stored submission in a sortable, paginated table and lets you:
Frontend
DataTablecomponent (components/DataTable/) split into focused pieces: orchestrator,useStoredFormDatahook, presentationalDataTableActions/DataTableGrid/DataTablePagination, and aCellsrenderer.helpers/datatable.ts(column ordering, item selection, field metadata) with vitest coverage; added avitest.config.tsso the package's self-referential imports resolve in tests.ReactTableloadable and added the@tanstack/react-tabledependency.Backend
FormDataStore: extracted the schema-field and record builders intoutils/datamanager.pywith type hints andTypedDictdefinitions (types.py), cached the requestblock_id, and added atotal_records_in_blockhelper — covered by new unit tests.FormSerializerblock serializer;SchemaFormBlockSerializeralready handles captcha props, attachments limit anddefault_field stripping forschemaFormblocks.Other
plone.formblockand frontendvolto).Closes #16