Skip to content

tiflash-proxy-next-gen: bind data key id from encryption meta (#10948)#10953

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:release-nextgen-202603from
ti-chi-bot:cherry-pick-10948-to-release-nextgen-202603
Jul 3, 2026
Merged

tiflash-proxy-next-gen: bind data key id from encryption meta (#10948)#10953
ti-chi-bot[bot] merged 1 commit into
pingcap:release-nextgen-202603from
ti-chi-bot:cherry-pick-10948-to-release-nextgen-202603

Conversation

@ti-chi-bot

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #10948

What problem does this PR solve?

Issue Number: ref #10952

Problem Summary:

What is changed and how it works?

Bump submodule contrib/tiflash-proxy-next-gen to pick up next-gen proxy data key id binding from encryption meta.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • Tested tiflash write can read data key generated by latest-release-tikv.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Summary by CodeRabbit

  • Chores
    • Updated a bundled subproject to a newer revision, which may include underlying improvements and fixes.

…p#10948)

ref tidbcloud/cloud-storage-engine#5484

Bump submodule contrib/tiflash-proxy-next-gen to pick up next-gen proxy data key id binding from encryption meta.

Signed-off-by: Bisheng Huang <hbisheng@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-202603 labels Jul 3, 2026
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)
  • release-8.5
  • release-7.5
  • release-8.1

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ecc60a28-ac4b-4168-9465-cc90c31d0c40

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 3, 2026
@JaySon-Huang JaySon-Huang requested a review from yongman July 3, 2026 08:21
@JaySon-Huang

This comment was marked as off-topic.

@ti-chi-bot

This comment was marked as off-topic.

@ti-chi-bot

ti-chi-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@overvenus: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JaySon-Huang

Copy link
Copy Markdown
Contributor

/test pull-integration-next-gen-columnar

@ti-chi-bot

ti-chi-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, overvenus, yongman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,yongman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 3, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

[LGTM Timeline notifier]

Timeline:

  • 2026-07-03 08:21:18.25340895 +0000 UTC m=+373219.953788363: ☑️ agreed by JaySon-Huang.
  • 2026-07-03 09:19:17.240139119 +0000 UTC m=+376698.940518532: ☑️ agreed by yongman.

@hbisheng

hbisheng commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

/retest

@JaySon-Huang

Copy link
Copy Markdown
Contributor

/test pull-integration-next-gen-columnar

1 similar comment
@JaySon-Huang

Copy link
Copy Markdown
Contributor

/test pull-integration-next-gen-columnar

@ti-chi-bot ti-chi-bot Bot merged commit 1e1183a into pingcap:release-nextgen-202603 Jul 3, 2026
6 checks passed
@ti-chi-bot ti-chi-bot Bot deleted the cherry-pick-10948-to-release-nextgen-202603 branch July 3, 2026 16:48
@ti-chi-bot

Copy link
Copy Markdown
Member Author

@JaySon-Huang: cannot checkout pull-integration-next-gen-columnar: error checking out pull-integration-next-gen-columnar: exit status 1. output: error: pathspec 'pull-integration-next-gen-columnar' did not match any file(s) known to git

Details

In response to this:

/cherry-pick pull-integration-next-gen-columnar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-202603

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants