planner: simplify outer join other conditions by hawkingrei · Pull Request #66015 · pingcap/tidb

hawkingrei · 2026-02-04T04:22:03Z

What problem does this PR solve?

Issue Number: close #65994

Problem Summary:

OR logical constants in outer join other conditions (e.g. a=b OR 0) are not simplified, which prevents join key extraction and can lead to incorrect plans/results after predicate pushdown.

What changed and how does it work?

Apply predicate simplification to outer join OtherConditions to eliminate trivial OR constants and keep join keys.
Add regression coverage in predicate pushdown testdata and integration test for the OR-0 outer join case.
Record planner rule notes and test guidance updates.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

codecov · 2026-02-04T04:46:00Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.6685%. Comparing base (6ff1adf) to head (e327656).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #66015        +/-   ##
================================================
- Coverage   77.7600%   77.6685%   -0.0915%     
================================================
  Files          2001       1923        -78     
  Lines        546165     534896     -11269     
================================================
- Hits         424698     415446      -9252     
+ Misses       119805     119442       -363     
+ Partials       1662          8      -1654

Flag	Coverage Δ
integration	`41.4917% <100.0000%> (-6.6949%)`	⬇️
unit	`76.7450% <100.0000%> (+0.3610%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`56.7974% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`48.8783% <ø> (-12.0935%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hawkingrei · 2026-02-04T05:28:09Z

/check-issue-triage-complete

hawkingrei · 2026-02-04T05:30:15Z

/retest

pkg/planner/core/operator/logicalop/logical_join.go

qw4990 · 2026-02-04T06:29:43Z

pkg/planner/core/casetest/rule/testdata/predicate_pushdown_suite_in.json

      "select /* double_not_left_join_exec */ t0.k0, t2.k0 from t0 left join t2 on not not (t0.k0 = t2.k0) order by t0.k0, t2.k0",
      "select /* double_not_right_join_exec */ t0.k0, t2.k0 from t0 right join t2 on not not (t0.k0 = t2.k0) order by t2.k0, t0.k0",
-      "select /* double_not_semi_join_exec */ t0.k0 from t0 where exists (select 1 from t2 where not not (t0.k0 = t2.k0)) order by t0.k0"
+      "select /* double_not_semi_join_exec */ t0.k0 from t0 where exists (select 1 from t2 where not not (t0.k0 = t2.k0)) order by t0.k0",


What's double_not_semi_join_exec a label for this test case?

It's more like a comment or a prompt.

where not not (t0.k0 = t2.k0))

guo-shaoge · 2026-02-04T07:11:43Z

pkg/planner/core/operator/logicalop/logical_join.go

+	// However, we still need to eliminate obvious logical constants in OtherConditions
+	// (e.g. "a = b OR 0") to avoid losing join keys.
+	p.OtherConditions = ruleutil.ApplyPredicateSimplificationForJoin(
+		p.SCtx(),


Do we need to call this function for other join types, like semi/anti/inner?
Also we can move this function call inside PredicatePushDown, becase there is no much logic, and a new function seems meanless.

Great, I have rafactored this code.

Signed-off-by: Weizhen Wang <[email protected]>

hawkingrei · 2026-02-04T08:00:14Z

/retest

ti-chi-bot · 2026-02-04T08:12:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [guo-shaoge]
~~pkg/planner/OWNERS~~ [guo-shaoge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2026-02-04T08:12:42Z

[LGTM Timeline notifier]

Timeline:

2026-02-04 08:12:42.548398664 +0000 UTC m=+254633.649797379: ☑️ agreed by guo-shaoge.

hawkingrei · 2026-02-04T08:30:13Z

/retest

Signed-off-by: Weizhen Wang <[email protected]>

hawkingrei · 2026-02-04T08:45:07Z

/retest

Signed-off-by: Weizhen Wang <[email protected]>

hawkingrei · 2026-02-04T09:06:25Z

/retest

Signed-off-by: Weizhen Wang <[email protected]>

hawkingrei · 2026-02-04T11:20:49Z

/retest

hawkingrei · 2026-02-04T15:00:59Z

/retest

hawkingrei added 2 commits February 4, 2026 12:04

planner: simplify outer join other conditions

f85a296

docs: record predicate pushdown test notes

f714931

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/planner SIG: Planner labels Feb 4, 2026

hawkingrei added AI-Testing AI-Correction Bugfix by AI and removed do-not-merge/needs-triage-completed labels Feb 4, 2026

tests: add data for outer join OR-constant case

781eaa0

ti-chi-bot bot added the do-not-merge/needs-triage-completed label Feb 4, 2026

hawkingrei added type/bugfix This PR fixes a bug. type/stale This issue has not been updated for a long time. and removed do-not-merge/needs-triage-completed labels Feb 4, 2026

qw4990 reviewed Feb 4, 2026

View reviewed changes

pkg/planner/core/operator/logicalop/logical_join.go Outdated Show resolved Hide resolved

qw4990 reviewed Feb 4, 2026

View reviewed changes

hawkingrei requested a review from qw4990 February 4, 2026 06:56

guo-shaoge reviewed Feb 4, 2026

View reviewed changes

hawkingrei added 2 commits February 4, 2026 15:21

planner: simplify join other conditions for all join types

9f69cc8

simplify code

706bd54

Signed-off-by: Weizhen Wang <[email protected]>

guo-shaoge approved these changes Feb 4, 2026

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 4, 2026

update join type limit

26765e7

Signed-off-by: Weizhen Wang <[email protected]>

update join type limit

75e4a70

Signed-off-by: Weizhen Wang <[email protected]>

update join type limit

e327656

Signed-off-by: Weizhen Wang <[email protected]>

Conversation

hawkingrei commented Feb 4, 2026

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

codecov bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hawkingrei commented Feb 4, 2026

Uh oh!

hawkingrei commented Feb 4, 2026

Uh oh!

Uh oh!

qw4990 Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

hawkingrei Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

hawkingrei Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

guo-shaoge Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

guo-shaoge Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

hawkingrei Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hawkingrei commented Feb 4, 2026

Uh oh!

ti-chi-bot bot commented Feb 4, 2026

Uh oh!

ti-chi-bot bot commented Feb 4, 2026

[LGTM Timeline notifier]

Uh oh!

hawkingrei commented Feb 4, 2026

Uh oh!

hawkingrei commented Feb 4, 2026

Uh oh!

hawkingrei commented Feb 4, 2026

Uh oh!

hawkingrei commented Feb 4, 2026

Uh oh!

hawkingrei commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Feb 4, 2026 •

edited

Loading

hawkingrei Feb 4, 2026 •

edited

Loading