-
Notifications
You must be signed in to change notification settings - Fork 6.1k
*: add the new SEMv2 config and implement most of the functions #61634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Don't be afraid of the lines dear reviewers! Most of them are just tests! |
b5fc0f5 to
be8a5ef
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #61634 +/- ##
================================================
+ Coverage 72.7869% 74.9377% +2.1507%
================================================
Files 1812 1864 +52
Lines 493988 504033 +10045
================================================
+ Hits 359559 377711 +18152
+ Misses 112580 103109 -9471
- Partials 21849 23213 +1364
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
8fbc4ac to
3a73dc4
Compare
4280a89 to
efe243e
Compare
|
/retest |
8e64cdf to
f6a93d9
Compare
|
/retest |
AilinKid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
planner part LGTM
GMHDBJD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
windtalker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, bb7133, CbcWestwolf, GMHDBJD, windtalker, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Signed-off-by: Yang Keao <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
|
/retest |
6 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
What problem does this PR solve?
Issue Number: close #61582, close #61583, close #61584, close #61585
Problem Summary:
The legacy SEM has many hard coded rules. This PR introduced a new SEM mechanism to make it possible to update the SEM rules without changing the code.
What changed and how does it work?
security.sem-config./pkg/util/sem/v2to parse this sem config./pkg/util/sem/compat.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.