Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an “HPC build” mode that disables architecture-specific/aggressive compiler optimizations and wires it through packaging/docs/CI to produce a more portable wheel artifact.
Changes:
- Add
DSF_HPC_BUILDCMake option and propagate it fromsetup.pyvia env var. - Update CI workflow to build standard + HPC variants and rename HPC wheel artifacts.
- Document the HPC variant installation/build steps in the README.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| setup.py | Reads DSF_HPC_BUILD env var and forwards -DDSF_HPC_BUILD=ON to CMake |
| CMakeLists.txt | Adds DSF_HPC_BUILD option and switches Release optimization flags accordingly |
| .github/workflows/pypi.yml | Builds a matrix of standard/hpc wheels and renames HPC wheels with _hpc suffix |
| README.md | Adds documentation for HPC wheel variant and local HPC builds |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
=======================================
Coverage 87.27% 87.27%
=======================================
Files 52 52
Lines 6461 6461
Branches 717 717
=======================================
Hits 5639 5639
Misses 803 803
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
69f7a58 to
1cc1000
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.