Skip to content

Fix assertSuperType logic #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 2.1.x
Choose a base branch
from
Open

Fix assertSuperType logic #4067

wants to merge 2 commits into from
+97 −5

Conversation

vojtech-dobes
Copy link
Contributor

So this should actually make assertSuperType work in the wilderness, but I fail to see how to test it. It seems like the FileAssertRule needs to reimplement the logic for itself.

@vojtech-dobes vojtech-dobes force-pushed the fix-assertSuperType branch 2 times, most recently from babd0a4 to 9f9d133 Compare June 20, 2025 15:05
ondrejmirtes
ondrejmirtes requested changes Jun 23, 2025
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if this had an actual test (failing without changes in src/). There's TypeInferenceTestCaseTest you can use.

@vojtech-dobes
Copy link
Contributor Author

Would be nice if this had an actual test (failing without changes in src/). There's TypeInferenceTestCaseTest you can use.

Tests added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vojtech-dobes @ondrejmirtes