Skip to content

fpm: calculate accurate process counts from states during status generation #18960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: PHP-8.1
Choose a base branch
from
+21 −11
Open

fpm: calculate accurate process counts from states during status generation #18960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions sapi/fpm/fpm/fpm_status.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,15 +65,25 @@ int fpm_status_export_to_zval(zval *status)
struct fpm_scoreboard_proc_s procs[scoreboard.nprocs];

struct fpm_scoreboard_proc_s *proc_p;
int calculated_active = 0, calculated_idle = 0;
for(i=0; i<scoreboard.nprocs; i++) {
proc_p = fpm_scoreboard_proc_acquire(scoreboard_p, i, 1);
if (!proc_p){
procs[i].used=-1;
continue;
}
procs[i] = *proc_p;
fpm_scoreboard_proc_release(proc_p);
}
proc_p = fpm_scoreboard_proc_acquire(scoreboard_p, i, 1);
if (!proc_p){
procs[i].used=-1;
continue;
}
procs[i] = *proc_p;

if (proc_p->used) {
if (proc_p->request_stage == FPM_REQUEST_ACCEPTING) {
calculated_idle++;
} else {
calculated_active++;
}
}

fpm_scoreboard_proc_release(proc_p);
}
fpm_scoreboard_release(scoreboard_p);

now_epoch = time(NULL);
Expand All @@ -88,9 +98,9 @@ int fpm_status_export_to_zval(zval *status)
add_assoc_long(status, "listen-queue", scoreboard.lq);
add_assoc_long(status, "max-listen-queue", scoreboard.lq_max);
add_assoc_long(status, "listen-queue-len", scoreboard.lq_len);
add_assoc_long(status, "idle-processes", scoreboard.idle);
add_assoc_long(status, "active-processes", scoreboard.active);
add_assoc_long(status, "total-processes", scoreboard.idle + scoreboard.active);
add_assoc_long(status, "idle-processes", calculated_idle);
add_assoc_long(status, "active-processes", calculated_active);
add_assoc_long(status, "total-processes", calculated_idle + calculated_active);
add_assoc_long(status, "max-active-processes", scoreboard.active_max);
add_assoc_long(status, "max-children-reached", scoreboard.max_children_reached);
add_assoc_long(status, "slow-requests", scoreboard.slow_rq);
Expand Down
Loading