Skip to content

Update the definition of the Z pack format code #4696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2025
Merged

Conversation

27pchrisl
Copy link
Contributor

a and Z had the same definition, but Z is the NUL-terminated variation.

a and Z had the same definition, but Z looks like the NUL-terminated variation.
@nielsdos
Copy link
Member

It's actually NUL terminated, and padded in some cases: https://3v4l.org/WGYGn
Not sure how to communicate this in the best way

@27pchrisl
Copy link
Contributor Author

Perl’s doc says “A null-terminated (ASCIZ) string, will be null padded.”, that seems clear? https://perldoc.perl.org/functions/pack. - could use their definition for A as well to make the distinction

@nielsdos
Copy link
Member

Yes that description is better

@27pchrisl
Copy link
Contributor Author

I've updated the description. I did look at the A description as well, but I think it's clear enough as it is.

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nielsdos nielsdos merged commit ad0f1ea into php:master Jun 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants