Skip to content

Docker retag yaml added #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions .github/workflows/test-docker-retag.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
on:
pull_request:
paths-ignore:
- "docs/**"
- "helm/**"
- "assets/**"
- "**.md"
name: Docker Retag from Edge
jobs:
docker-retag:
runs-on: ubuntu-latest

steps:
- name: Login to Docker Hub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Extract Tag or SHA
id: meta
run: |
if [[ "${{ github.event_name }}" == "push" ]]; then
TAG_NAME="${GITHUB_REF#refs/tags/}"
else
TAG_NAME="test-pr-${GITHUB_SHA::7}"
fi
Comment on lines +23 to +30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Unreachable 'push' branch in tag extraction

The if [[ "${{ github.event_name }}" == "push" ]] branch will never execute because the workflow only triggers on pull_request. Either add a push trigger or simplify/remove the unused conditional.

🤖 Prompt for AI Agents
In .github/workflows/test-docker-retag.yaml around lines 23 to 30, the
conditional checking if github.event_name is "push" is unreachable because the
workflow triggers only on pull_request events. To fix this, either add a push
trigger to the workflow triggers section to allow the push branch to execute or
simplify the script by removing the conditional and only handling the
pull_request case.

echo "tag=$TAG_NAME" >> "$GITHUB_OUTPUT"

- name: Retag from edge and push
run: |
docker buildx imagetools create \
--tag parseable/parseable:${{ steps.meta.outputs.tag }} \
parseable/parseable:edge

- name: Inspect new tag (optional)
run: |
docker buildx imagetools inspect parseable/parseable:${{ steps.meta.outputs.tag }}
Loading