fix for converting arrows to parquet #1182
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-sh
reviewed
Feb 10, 2025
src/staging/streams.rs
Outdated
| arrow_files = arrow_files | ||
| .into_iter() | ||
| .filter(|path| { | ||
| let created_at = path.metadata().unwrap().created().unwrap(); |
Contributor
There was a problem hiding this comment.
This will panic if run against a certain few filesystems like btrfs ref
de-sh
reviewed
Feb 10, 2025
Contributor
de-sh
left a comment
de-sh
left a comment
There was a problem hiding this comment.
The PR will break support for time-partitioning, file in object store will have file created time and not the timestamp in the log
nikhilsinhaparseable
force-pushed
the
conversion-fix
branch
from
40c9b26 to
174853d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #XXXX.
Description
This PR has: