feat: add minifyWhitespace override option#1158
Open
zalishchuk wants to merge 3 commits intoparcel-bundler:masterfrom
Open
feat: add minifyWhitespace override option#1158zalishchuk wants to merge 3 commits intoparcel-bundler:masterfrom
minifyWhitespace override option#1158zalishchuk wants to merge 3 commits intoparcel-bundler:masterfrom
Conversation
yisibl
reviewed
Feb 23, 2026
| }); | ||
|
|
||
| assert.equal(res.code.toString(), '.a{color:red}.a{color:#00f}'); | ||
| }); |
Contributor
There was a problem hiding this comment.
Perhaps adding some tests for at-rules and CSS functions would be beneficial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new
minifyWhitespaceoption (JS/NAPI) and matching CLI flags (--minify-whitespace/--no-minify-whitespace) so users can control output whitespace/newlines separately from semantic minification.This is mainly to fix the confusing case where
minify: falsewould still "beautify" the output (add spaces/newlines) even if the input was already compact.Behavior:
minifyWhitespaceis omitted, formatting still followsminifylike before (old behavior preserved).minifyWhitespaceis provided, behavior is decoupled:minifycontrols semantic optimizationsminifyWhitespacecontrols serializer whitespace/newlinesExamples:
minify: false, minifyWhitespace: true-> no semantic optimizations + compact outputminify: true, minifyWhitespace: false-> semantic optimizations + pretty outputThis stays non-breaking for existing JS/CLI users.