chore: update Boa to v0.21.0
#375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like CI doesn't run probably because it's from fork. |
mattsse
reviewed
Oct 27, 2025
Contributor
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
a few breaking changes, but dont look too bad
Contributor
Author
|
|
Contributor
Author
|
@mattsse I managed to make it work. Could you take a look at it again? Thanks. |
Gumichocopengin8
force-pushed
the
chore/update-boa-0.21.0
branch
from
a412cbd to
13fc628
Compare
Contributor
|
amazing |
Gumichocopengin8
changed the title
Boa to v0.21.0
DaniPopes
reviewed
Oct 31, 2025
| }) | ||
| } else { | ||
| val.to_json(ctx) | ||
| val.to_json(ctx)?.ok_or_else(|| { |
Member
There was a problem hiding this comment.
returns None for undefined, looks fine https://docs.rs/boa_engine/latest/boa_engine/value/struct.JsValue.html#method.to_json
DaniPopes
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update boa to v0.21.0. More conformance improvements and bug fixes.
https://github.com/boa-dev/boa/blob/main/CHANGELOG.md#v0210