Skip to content

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 11, 2025

this removes the rpc cache roundtrip for just the header, most of the time the block will be the latest one that we have in mem, if not then it's also likely that we dont have it cached in which cases directly reading the header is better than going through the cache here

ref

#20059

@mattsse mattsse requested a review from Rjected as a code owner December 11, 2025 09:19
@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Dec 11, 2025
@mattsse mattsse requested a review from klkvr December 11, 2025 09:19
@mattsse mattsse added C-perf A change motivated by improving speed, memory usage or disk footprint A-rpc Related to the RPC implementation labels Dec 11, 2025
@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Dec 11, 2025
@mattsse mattsse added this pull request to the merge queue Dec 11, 2025
Merged via the queue into main with commit a2a5e03 Dec 11, 2025
46 checks passed
@mattsse mattsse deleted the matt/query-header-directly branch December 11, 2025 11:27
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Dec 11, 2025
mattsse added a commit that referenced this pull request Dec 11, 2025
Vui-Chee added a commit to okx/reth that referenced this pull request Dec 12, 2025
…number

* upstream: (203 commits)
  feat(node-core): make rpc server args customizable (paradigmxyz#20312)
  feat: add `account_history_in_rocksdb` field to `StorageSettings` (paradigmxyz#20282)
  feat(engine): Add BAL stub methods to ExecutionPayload and BlockOrPayload (paradigmxyz#20311)
  docs: fix misleading links (paradigmxyz#20300)
  ci: add more sccache (paradigmxyz#20316)
  feat: bump alloy-evm (paradigmxyz#20314)
  feat: allow larger ws frames on client side (paradigmxyz#20307)
  docs: add architecture diagrams to ExEx documentation (paradigmxyz#20193)
  feat: add semaphore for blocking IO requests (paradigmxyz#20289)
  ci: scale down depot runners (paradigmxyz#20295)
  perf: fetch header directly (paradigmxyz#20294)
  docs(exex): fix DebugApi comment (paradigmxyz#20296)
  feat: add support for testing_ rpc namespace and testing_buildBlockV1 (paradigmxyz#20094)
  chore: update engine_getBlobs metric (paradigmxyz#20290)
  chore(optimism): move predeploy constant to op-alloy (paradigmxyz#20181)
  docs: fix stages order and add missing EraStage (paradigmxyz#20283)
  docs: improve map_add_ons method documentation (paradigmxyz#20248)
  feat: add `transaction_hash_numbers_in_rocksdb` field to `StorageSettings` (paradigmxyz#20209)
  docs: clarify network mode, tx gossip and NAT (paradigmxyz#20247)
  feat: add support for debug_getBadBlock (paradigmxyz#20177)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation C-perf A change motivated by improving speed, memory usage or disk footprint

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants