Skip to content

Add RocksDB routing variants to Either* #20284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yongkangc wants to merge 2 commits into from
Closed

Add RocksDB routing variants to Either* #20284

yongkangc wants to merge 2 commits into from

Conversation

@yongkangc
Copy link
Member

@yongkangc yongkangc commented Dec 11, 2025

Closes #20278
Closes #20279
Closes #20280

@yongkangc
feat: add account_history_in_rocksdb field to StorageSettings
19f9d2a 
Closes #20150

Adds configuration flag to control whether `AccountsHistory` table is stored in RocksDB, enabling future hot/cold storage separation for this 93GB+ index table.
@yongkangc
Add RocksDB routing variants to Either*
99d30c3
@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Dec 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

Your PR title doesn't follow the Conventional Commit guidelines.

Example of valid titles:

  • feat: add new user login
  • fix: correct button size
  • docs: update README

Usage:

  • feat: Introduces a new feature
  • fix: Patches a bug
  • chore: General maintenance tasks or updates
  • test: Adding new tests or modifying existing tests
  • bench: Adding new benchmarks or modifying existing benchmarks
  • perf: Performance improvements
  • refactor: Changes to improve code structure
  • docs: Documentation updates
  • ci: Changes to CI/CD configurations
  • revert: Reverts a previously merged PR
  • deps: Updates dependencies

Breaking Changes

Breaking changes are noted by using an exclamation mark. For example:

  • feat!: changed the API
  • chore(node)!: Removed unused public function

Help

For more information, follow the guidelines here: https://www.conventionalcommits.org/en/v1.0.0/

@github-actions github-actions bot added the C-enhancement New feature or request label Dec 11, 2025
@yongkangc yongkangc closed this Dec 11, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Reth Tracker Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rakita rakita Awaiting requested review from rakita rakita will be requested when the pull request is marked ready for review rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo will be requested when the pull request is marked ready for review joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin will be requested when the pull request is marked ready for review shekhirin is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse will be requested when the pull request is marked ready for review mattsse is a code owner

Assignees

No one assigned

Labels

C-enhancement New feature or request

Projects

Reth Tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add EitherWriterDestination::RocksDB Add RocksDB variant to EitherWriter Add RocksDB variant to EitherReader

2 participants

@yongkangc