Skip to content

perf: batch key/value length reads in EtlFile #20207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gap-editor wants to merge 1 commit into from
Closed

perf: batch key/value length reads in EtlFile #20207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions crates/etl/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,14 +259,13 @@ impl EtlFile {
return Ok(None)
}

let mut buffer_key_length = [0; KV_LEN];
let mut buffer_value_length = [0; KV_LEN];
// Optimization: Read both key and value lengths (2 * 8 bytes) in a single syscall
let mut len_buf = [0u8; 2 * KV_LEN];
self.file.read_exact(&mut len_buf)?;

self.file.read_exact(&mut buffer_key_length)?;
self.file.read_exact(&mut buffer_value_length)?;
let key_length = usize::from_be_bytes(len_buf[..KV_LEN].try_into().unwrap());
let value_length = usize::from_be_bytes(len_buf[KV_LEN..].try_into().unwrap());

let key_length = usize::from_be_bytes(buffer_key_length);
let value_length = usize::from_be_bytes(buffer_value_length);
let mut key = vec![0; key_length];
let mut value = vec![0; value_length];

Expand Down
Loading