BUG: Handle unit count when converting from np.datetime64
#58915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Jun 4, 2024
| """ | ||
| returns the number of units of the dtype for a numpy datetime64 object. | ||
| """ | ||
| return (<PyDatetimeScalarObject*>obj).obmeta.num |
There was a problem hiding this comment.
What does number of units mean exactly? And is there a public way to get this - I am wary of relying up internals llike this
|
I think this case is rare enough I’d rather not support it at all than support is inconsistently across the codebase. Iirc @seberg was thinking of deprecating it in numpy too |
|
Yeah, I suspect very few use that really and unless someone would shout, I would be fine with deprecating it. I would also suspect NumPy also has bugs around it due to it having at least almost no users in practice. |
|
Any interest in adding a warning or putting a note in the docs? Otherwise, I'll close this PR. |
|
Looks like there not much appetite for this change so closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.