Skip to content

ENH: Enabled skipna argument on groupby reduction ops #15675 #58844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e13428b
ENH: Enabled skipna argument on groupby reduction ops (#15675)
andremcorreia May 27, 2024
8099d84
FIX: fixed pipeline issues related to docs and window tests
tiago-firmino May 27, 2024
8f61fda
Fix: pre-commit
andremcorreia May 27, 2024
2518696
Reworked sugestions
andremcorreia Jun 2, 2024
5cd994c
Reworked documentation
tiago-firmino Jun 2, 2024
8ae0caf
FIX: resample redefinition
tiago-firmino Jun 2, 2024
5e3a965
FIX: Small tweaks in docs
andremcorreia Jun 2, 2024
c692076
Refactored test parameterization
andremcorreia Jun 9, 2024
e87e030
Added tests for EAs
tiago-firmino Jun 11, 2024
4f11dab
Removed Arrow support
andremcorreia Jun 11, 2024
edbb331
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 11, 2024
3d719b8
pre-commit fix
andremcorreia Jun 11, 2024
c2ceb57
Merge branch 'add_skipna_on_groupby_ops_pr' of github.com:andremcorre…
andremcorreia Jun 11, 2024
2856c6d
WIP EAs support
tiago-firmino Jun 14, 2024
c200177
Extension Array Support Tests
andremcorreia Jul 4, 2024
66e0ee4
Merge branch 'main' into add_skipna_on_groupby_ops_pr
andremcorreia Jul 4, 2024
262ca97
WIP: Fixing Tests
andremcorreia Jul 4, 2024
91bb3c3
WIP: 32bit fix
andremcorreia Jul 4, 2024
7ee07d1
WIP: overflow
tiago-firmino Aug 3, 2024
bae5217
Merge branch 'main' into add_skipna_on_groupby_ops_pr
andremcorreia Aug 4, 2024
5a004cf
Fix tests 32bit
andremcorreia Aug 4, 2024
0ef070c
small tweaks
andremcorreia Aug 4, 2024
d02b308
simpler test skipping approach
andremcorreia Aug 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v3.0.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ Other enhancements
- :meth:`Styler.format_index_names` can now be used to format the index and column names (:issue:`48936` and :issue:`47489`)
- :class:`.errors.DtypeWarning` improved to include column names when mixed data types are detected (:issue:`58174`)
- :func:`DataFrame.to_excel` argument ``merge_cells`` now accepts a value of ``"columns"`` to only merge :class:`MultiIndex` column header header cells (:issue:`35384`)
- :meth:`.DataFrameGroupBy.sum`, :meth:`.DataFrameGroupBy.prod`, :meth:`.DataFrameGroupBy.min`, :meth:`.DataFrameGroupBy.max`, :meth:`.DataFrameGroupBy.mean`, :meth:`.DataFrameGroupBy.median`, :meth:`.DataFrameGroupBy.sem`, :meth:`.DataFrameGroupBy.std` and :meth:`.DataFrameGroupBy.var` now accept a skipna argument. (:issue:`15675`)
- :meth:`DataFrame.corrwith` now accepts ``min_periods`` as optional arguments, as in :meth:`DataFrame.corr` and :meth:`Series.corr` (:issue:`9490`)
- :meth:`DataFrame.cummin`, :meth:`DataFrame.cummax`, :meth:`DataFrame.cumprod` and :meth:`DataFrame.cumsum` methods now have a ``numeric_only`` parameter (:issue:`53072`)
- :meth:`DataFrame.ewm` now allows ``adjust=False`` when ``times`` is provided (:issue:`54328`)
Expand Down
7 changes: 7 additions & 0 deletions pandas/_libs/groupby.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ def group_median_float64(
mask: np.ndarray | None = ...,
result_mask: np.ndarray | None = ...,
is_datetimelike: bool = ..., # bint
skipna: bool = ..., # bint
) -> None: ...
def group_cumprod(
out: np.ndarray, # float64_t[:, ::1]
Expand Down Expand Up @@ -66,6 +67,7 @@ def group_sum(
result_mask: np.ndarray | None = ...,
min_count: int = ...,
is_datetimelike: bool = ...,
skipna: bool = ..., # bint
) -> None: ...
def group_prod(
out: np.ndarray, # int64float_t[:, ::1]
Expand All @@ -75,6 +77,7 @@ def group_prod(
mask: np.ndarray | None,
result_mask: np.ndarray | None = ...,
min_count: int = ...,
skipna: bool = ..., # bint
) -> None: ...
def group_var(
out: np.ndarray, # floating[:, ::1]
Expand All @@ -86,6 +89,7 @@ def group_var(
mask: np.ndarray | None = ...,
result_mask: np.ndarray | None = ...,
is_datetimelike: bool = ...,
skipna: bool = ..., # bint
name: str = ...,
) -> None: ...
def group_skew(
Expand All @@ -104,6 +108,7 @@ def group_mean(
labels: np.ndarray, # const intp_t[:]
min_count: int = ..., # Py_ssize_t
is_datetimelike: bool = ..., # bint
skipna: bool = ..., # bint
mask: np.ndarray | None = ...,
result_mask: np.ndarray | None = ...,
) -> None: ...
Expand Down Expand Up @@ -170,6 +175,7 @@ def group_max(
labels: np.ndarray, # const int64_t[:]
min_count: int = ...,
is_datetimelike: bool = ...,
skipna: bool = ..., # bint
mask: np.ndarray | None = ...,
result_mask: np.ndarray | None = ...,
) -> None: ...
Expand All @@ -180,6 +186,7 @@ def group_min(
labels: np.ndarray, # const int64_t[:]
min_count: int = ...,
is_datetimelike: bool = ...,
skipna: bool = ..., # bint
mask: np.ndarray | None = ...,
result_mask: np.ndarray | None = ...,
) -> None: ...
Expand Down
Loading
Loading