-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: Fix is_unique
regression for slices of Index
es
#57958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e14f3e5
Fix is_unique for slices of Indexes
rob-sil 78bca47
Merge branch 'main' into index-is_unique-slice
rob-sil 360aa3b
Update doc/source/whatsnew/v2.2.2.rst
rob-sil 4ab184b
Handle monotonic on slices
rob-sil 3fb2b4f
Restore and fix monotonic code
rob-sil 4916d5c
Merge branch 'main' into index-is_unique-slice
rob-sil 512ba5c
Update docstring and comment for test
rob-sil 06e21ab
Merge branch 'main' into index-is_unique-slice
rob-sil 8aff236
Update whatsnew for v3.0.0
rob-sil 1d68e8e
Update pandas/_libs/index.pyx
mroeschke 3f5bdca
Update pandas/_libs/index.pyx
rob-sil 8a2fd84
Add test for a null slice
rob-sil dc2ce58
Merge branch 'main' into index-is_unique-slice
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -964,6 +964,27 @@ def test_slice_keep_name(self): | |
index = Index(["a", "b"], name="asdf") | ||
assert index.name == index[1:].name | ||
|
||
def test_slice_is_unique(self): | ||
# GH 57911 | ||
index = Index([1, 1, 2, 3, 4]) | ||
assert not index.is_unique | ||
filtered_index = index[2:].copy() | ||
assert filtered_index.is_unique | ||
|
||
def test_slice_is_montonic(self): | ||
"""Test that is_monotonic_decreasing is correct on slices.""" | ||
# GH 57911 | ||
index = Index([1, 2, 3, 3]) | ||
assert not index.is_monotonic_decreasing | ||
|
||
filtered_index = index[2:].copy() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you also test a null slice i.e. |
||
assert filtered_index.is_monotonic_decreasing | ||
assert filtered_index.is_monotonic_increasing | ||
|
||
filtered_index = index[1:].copy() | ||
assert not filtered_index.is_monotonic_decreasing | ||
assert filtered_index.is_monotonic_increasing | ||
|
||
@pytest.mark.parametrize( | ||
"index", | ||
[ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.