Skip to content

Restore nightly CI build due to new pandas version (3.0.0) #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 7, 2024

Conversation

loicdiridollou
Copy link
Member

We can probably be a little more elegant in some of the pytest_warn_bounds where we define a variable then redefine it the line below if we are dealing with pandas 3.0.0, open to suggestions.

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Aug 7, 2024

We can probably be a little more elegant in some of the pytest_warn_bounds where we define a variable then redefine it the line below if we are dealing with pandas 3.0.0, open to suggestions.

I'm open to better ways of doing the tests here, but will accept this PR as is.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr-Irv Dr-Irv merged commit b3967c9 into pandas-dev:main Aug 7, 2024
13 checks passed
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Aug 7, 2024

@loicdiridollou looks like the fix for test_versions() didn't work. See https://github.com/pandas-dev/pandas-stubs/actions/runs/10289869197/job/28478532479

@loicdiridollou
Copy link
Member Author

Arghh I thought I had it fixed, sorry for that let me investigate and fix.

@loicdiridollou
Copy link
Member Author

I was able to have a running build on my own repo, see https://github.com/loicdiridollou/pandas-stubs/actions/runs/10290769879/job/28481506269.
The PR is here (#975), the issue was that pandas>=3.0.0 does not seem to rely on distutils anymore so the warning was never raised to the user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore nightly CI build due to new pandas version (3.0.0)
2 participants