-
-
Notifications
You must be signed in to change notification settings - Fork 145
Delete undocumented functions #1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You're getting some errors. I'm OK if you remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. I found other things you can delete.
For some of the files, there are just whitespace changes - not sure why. E.g., pandas-stubs/io/sas/sasreader.pyi
. Not sure why that is happening.
Thanks for the review! I'll clean things up later today or tomorrow Not sure why there were a bunch of whitespace changes, I thought libCST was supposed to be whitespace-preserving. |
CI is showing that deleting |
Maybe we save the trickier part for a separate PR, since this one is already kind of large. |
Well now |
So I think this is good to go. Feel free to take it out of Draft status and ping for final approve/merge |
Cool, ready to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yangdanny97
Found using a script as described in #1253
I did not delete anything in
_testing
, since I assumed they are test helpers.Deletion performed automatically using a libCST codemod script: https://gist.github.com/yangdanny97/5d07f14527ac46035208a8119f3cfca2