Fix template decorators to work without parentheses #5743
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where template decorators like @app.template_filter don't work when used without parentheses. The fix allows the decorators to be used in both ways: - @app.template_filter - @app.template_filter() The following decorators have been fixed: - template_filter, template_test, template_global in Flask - app_template_filter, app_template_test, app_template_global in Blueprint Fixes pallets#5729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where template decorators like
@app.template_filterdon't work when used without parentheses. The fix allows the decorators to be used in both ways:@app.template_filter(without parentheses)@app.template_filter()(with empty parentheses)@app.template_filter("my_filter")(with a name argument)The following decorators have been fixed:
template_filter,template_test,template_globalin Flaskapp_template_filter,app_template_test,app_template_globalin BlueprintChanges
Related Issue
Fixes #5729
Testing
Added tests in
tests/test_decorator_no_parens.pyto verify that all the decorators work without parentheses.Pull Request opened by Augment Code with guidance from the PR author