Dashboard frontend for Log Detective API in packit#526
Dashboard frontend for Log Detective API in packit#526jpodivin wants to merge 3 commits intopackit:mainfrom
Conversation
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 38s |
lbarcziova
left a comment
lbarcziova
left a comment
There was a problem hiding this comment.
there seems to be a lot of code that ends up not being displayed. Is the goal of this PR only to have a view for a single result view that can be linked from the commit status in Pagure, or also a table for displaying multiple results (which should then be navigable from somewhere).
To me, having the single result view works as I don't see a use case for viewing all the analyses generally. Based on that, the table-related code could be removed.
Also, we don't have any code for displaying groups for other job types, so please remove the related code.
| <DescriptionListGroup> | ||
| <DescriptionListTerm>Analysis ID</DescriptionListTerm> | ||
| <DescriptionListDescription> | ||
| {data.analysis_id} |
There was a problem hiding this comment.
it could be beneficial to be able to go back to the koji/copr build view from here, but we can leave it as follow-up
I'd like to keep the group view in, even if it is not immediately useful, for debugging purposes. I'd also like to keep list view for similar reasons, having a way to see all recent responses from Log Detective would be helpful if we ever encounter odd behavior and want to establish a pattern. Otherwise we would have to pull it from API directly, which is possible, but not very comfortable. |
jpodivin
force-pushed
the
logdetective_report
branch
from
930a1ea to
41168f3
Compare
|
Preview: https://packit-dashboard-pr-526.surge.sh (deployed at Fri 27 Mar 2026, 08:39 UTC) |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 40s |
lbarcziova
left a comment
lbarcziova
left a comment
There was a problem hiding this comment.
functionally, this looks good to me, after trying out the new views locally. I'm fine to keep the list and groups without navigation for now for debugging purposes, but let's revisit later if we should add the navigation also, if this would be useful for users too.
jpodivin
force-pushed
the
logdetective_report
branch
from
41168f3 to
aa773de
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 38s |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 38s |
We will only be using text field from the Log Detective response. Other fields are not used at the moment, and may in fact be removed in near future. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
jpodivin
force-pushed
the
logdetective_report
branch
from
7bc16ff to
271b415
Compare
|
This is how it should all look: 
|
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 38s |
3 participants
We will only be using text field from the Log Detective response. Other fields are not used at the moment, and may in fact be removed in near future.
Assisted-by: Claude Opus 4.6 noreply@anthropic.com
Merge after: packit/packit-service#3075
RELEASE NOTES BEGIN
Log Detective results are now displayed on the dashboard.
RELEASE NOTES END