Patch: setIconImage
#32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day.
The
setIconImagewill simply not work when we are dealing with a jar file, because the contents inside might not actually be located. In order to fix thatI added
BufferedImageCustom.javato read the content properly and throw an exception if the file (icon.png) cannot be located.The UI constructor, in order to accept a method that throws an exception, I added
throws IOException.The main method, in order to properly catch the exception, there should be the
try-catchblock.In order to mark this, I created another release, executable jar file included,
https://github.com/xdvrx1/Simple-Java-Calculator/releases/tag/v1.1.1
Again, the name of this release, is up to you when you want to include this in your repo.
Thank you so much!