Allow Backslash Escaping of Pipes #152 #176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lingo
changed the title
mwilck
requested changes
Sep 8, 2025
[email protected]/utilities.js
Outdated
| { | ||
| separatorIndex = lineString.indexOf("|", separatorIndex); | ||
| if (separatorIndex === 0 || lineString[separatorIndex-1] != '\\') { | ||
| // found a non-escaped pipe symbol |
Collaborator
There was a problem hiding this comment.
What if lineString[separatorIndex-2] is a backslash, too? 'one\\|two' should be split into ['one\', 'two'].
#65 has the same issue, AFAICT. Actually this kind of quoting is tricky to get right.
Author
There was a problem hiding this comment.
Good point. I was thinking to avoid some of the complexities of the regex engine and syntax, but it's true this also avoids some of the complexities of the problem itself!
Author
There was a problem hiding this comment.
I've updated the code to handle escaping better, hope this is useful.
Author
There was a problem hiding this comment.
My test file:
#!/usr/bin/env -S tail -n+2
Test
---
Try me one\| bash='zenity --info --text=Ok' terminal=false
Try me one\\| bash='zenity --info --text=Ok' terminal=false
Try me one\\\| bash='zenity --info --text=Ok' terminal=false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternate implementation of #65
to fix #152
Given that the existing pull request has sat there since 2018(?) perhaps this alternative is accepted?