Fix brittle JSON tests for Go 1.25 #1098
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at #1086
This PR updates the config_test.go file to make the JSON comparison tests more compatible with Go 1.25.
Changes made:
-Replaced direct byte-for-byte JSON comparisons with structural comparisons using normalizeJSON.
-Introduced normalizeJSON(t, b []byte) map[string]interface{} helper to unmarshal JSON into a map[string]interface{} for reliable comparison.
-Ensures both the default configuration and database configuration JSON tests pass consistently, regardless of formatting or encoding differences.
Testing:
-All tests in config_test.go pass successfully (go test ./config).