[MCP Integration] Phase 3: Config service#2236
Open
aniruddh-alt wants to merge 9 commits intoani/mcp-integration-02-modelsfrom
Open
[MCP Integration] Phase 3: Config service#2236aniruddh-alt wants to merge 9 commits intoani/mcp-integration-02-modelsfrom
aniruddh-alt wants to merge 9 commits intoani/mcp-integration-02-modelsfrom
Conversation
|
Important Upgrade your plan to unlock code review, CI analysis, custom rules, and more. |
aniruddh-alt
force-pushed
the
ani/mcp-integration-02-models
branch
from
f38a2e4 to
8e7a6b1
Compare
aniruddh-alt
force-pushed
the
ani/mcp-integration-03-config-svc
branch
from
fa4b9de to
68b1f3d
Compare
aniruddh-alt
force-pushed
the
ani/mcp-integration-02-models
branch
from
cbe787c to
4d3461e
Compare
aniruddh-alt
force-pushed
the
ani/mcp-integration-03-config-svc
branch
from
d5a2a5c to
f464b88
Compare
Add config_service.py for discovering, loading, and resolving Oumi YAML training configs from multiple sources (env override, cached, bundled). Includes comprehensive tests for config discovery and loading. Part of the MCP integration PR chain (Phase 3 of 10). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix TOCTOU race in config directory resolution (try/except vs check-then-use) - Fix extract_header_comment docstring to match actual behavior
aniruddh-alt
force-pushed
the
ani/mcp-integration-02-models
branch
from
4d3461e to
89c8856
Compare
aniruddh-alt
force-pushed
the
ani/mcp-integration-03-config-svc
branch
from
f464b88 to
a0a2e8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of the MCP Integration PR chain (Phase 3 of 10) - Stage: service
What changed: Added
config_service.pyfor discovering, loading, and resolving Oumi YAML training configs from multiple sources (env override, cached, bundled fallback) with comprehensive tests.Why: The config service is a core dependency for the sync service and server tools — it enables MCP clients to browse and use training configurations.
Related issues
Before submitting