[MCP Integration] Phase 1: Package scaffold and dependencies#2234
Open
aniruddh-alt wants to merge 8 commits intomainfrom
Open
[MCP Integration] Phase 1: Package scaffold and dependencies#2234aniruddh-alt wants to merge 8 commits intomainfrom
aniruddh-alt wants to merge 8 commits intomainfrom
Conversation
Add the oumi.mcp package skeleton with optional dependencies (fastmcp, httpx, huggingface-hub, mcp, pyyaml), the oumi-mcp console entry point, and ruff lint ignores for the MCP server code. Part of the MCP integration PR chain (Phase 1 of 10). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Upgrade your plan to unlock code review, CI analysis, custom rules, and more. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
aniruddh-alt
force-pushed
the
ani/mcp-integration-01-scaffold
branch
from
70e68d6 to
b35dc2d
Compare
- Remove unnecessary mcp[cli] extra (only fastmcp is used) - Add upper-bound pins to httpx and huggingface-hub deps - Narrow ASYNC ruff suppression to specific rules (210, 220, 230, 240)
aniruddh-alt
force-pushed
the
ani/mcp-integration-01-scaffold
branch
from
b35dc2d to
79de029
Compare
idoudali
reviewed
Mar 4, 2026
- Remove huggingface-hub and pyyaml (already transitive core deps) - Add upper bound to mcp dependency (<2) for consistency - Tighten ruff per-file-ignores to only ASYNC2xx rules - Add mcp to ci_cpu target so CI tests MCP code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jgreer013
reviewed
Mar 5, 2026
| @@ -0,0 +1,22 @@ | |||
| # Copyright 2025 - Oumi | |||
jgreer013
approved these changes
Mar 5, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
|
|
||
| [project.scripts] | ||
| oumi = "oumi.cli.main:run" | ||
| oumi-mcp = "oumi.mcp.server:main" |
There was a problem hiding this comment.
Bug: The oumi-mcp entry point in pyproject.toml points to oumi.mcp.server:main, but this module and function do not exist, causing a ModuleNotFoundError at runtime.
Severity: HIGH
Suggested Fix
Either remove the oumi-mcp entry point from pyproject.toml and add it in a future PR that implements the oumi.mcp.server:main function, or create a placeholder server.py file with a main function that provides a meaningful error message.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: pyproject.toml#L215
Potential issue: The `pyproject.toml` file defines a command-line entry point `oumi-mcp`
which is configured to execute the `main` function within the `oumi.mcp.server` module.
However, the `oumi.mcp.server` module does not exist in the codebase. As a result, any
user who installs the package with the `mcp` extra and attempts to run the `oumi-mcp`
command will encounter an immediate `ModuleNotFoundError` because the specified module
cannot be found, making the feature unusable.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of the MCP Integration PR chain (Phase 1 of 10) - Stage: scaffold
What changed: Added the
oumi.mcppackage skeleton with optional dependencies (fastmcp, httpx, huggingface-hub, mcp, pyyaml), theoumi-mcpconsole entry point, and ruff lint ignores.Why: This establishes the package structure and dependency declarations needed for the MCP server integration.
Related issues
Before submitting