Repository navigation
Keep withLoggingContextAsync entries off the thread MDC - #608
Open
timobraveweber wants to merge 1 commit into
Open
timobraveweber wants to merge 1 commit into
timobraveweber wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withLoggingContextAsyncputs its entries into the MDC of the current thread before it switches to anMDCContext. A body that resumes on another thread leaves the entries on the first thread. The cleanup then writes the previous values onto the second thread.Unrelated work on either thread logs with these entries.
The function now builds the
MDCContextfrom the current MDC plus the entries. It no longer writes the thread's MDC before the body. The three overloads are no longerinline, so a later fix reaches callers without a recompile. Callers compiled against 8.0.4 keep the old inlined code until they recompile.Fixes #607