Skip to content

Fix GraalVM native build error caused by stale substitution target in v8.x #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oshai merged 4 commits into from
May 3, 2026
+10 −7
Merged

Fix GraalVM native build error caused by stale substitution target in v8.x #601

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5594aa9
Initial plan
Copilot May 3, 2026
e93a9e7
Fix native build error: update GraalVM substitution onlyWith conditio…
Copilot May 3, 2026
5b822c2
Fix native build error: update GraalVM substitution to target KotlinL…
Copilot May 3, 2026
c634b54
Fix GraalVM substitution to preserve kotlin-logging-to-direct behavior
oshai May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions ..._kotlinlogging_internal_KLoggerFactory.kt → ...tlinlogging_KotlinLoggingConfiguration.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ package io.github.oshai.kotlinlogging.internal
import com.oracle.svm.core.annotate.Substitute
import com.oracle.svm.core.annotate.TargetClass
import com.oracle.svm.core.annotate.TargetElement
import io.github.oshai.kotlinlogging.KLogger
import io.github.oshai.kotlinlogging.DirectLoggerFactory
import io.github.oshai.kotlinlogging.KLoggerFactory
import io.github.oshai.kotlinlogging.jul.internal.JulLoggerFactory
import io.github.oshai.kotlinlogging.slf4j.internal.Slf4jLoggerFactory
import java.util.function.BooleanSupplier
Expand All @@ -16,21 +17,23 @@ import java.util.function.BooleanSupplier
* to convention.
*/
@Suppress("unused")
internal class Target_io_github_oshai_kotlinlogging_internal_KLoggerFactory {
internal class Target_io_github_oshai_kotlinlogging_KotlinLoggingConfiguration {
@TargetClass(
className = "io.github.oshai.kotlinlogging.internal.KLoggerFactory",
className = "io.github.oshai.kotlinlogging.KotlinLoggingConfiguration",
onlyWith = [LogbackNotOnClasspath::class],
)
companion object {
@Substitute
@TargetElement(name = "logger\$kotlin_logging")
fun logger(name: String): KLogger {
@TargetElement(name = "detectLogger")
fun detectLogger(): KLoggerFactory {
if (System.getProperty("kotlin-logging-to-jul") != null) {
return JulLoggerFactory.wrapJLogger(JulLoggerFactory.jLogger(name))
return JulLoggerFactory
} else if (System.getProperty("kotlin-logging-to-direct") == "true") {
return DirectLoggerFactory
}
// Intentionally leave out the logback branch as logback is not on the classpath.
// default to SLF4J
return Slf4jLoggerFactory.wrapJLogger(Slf4jLoggerFactory.jLogger(name))
return Slf4jLoggerFactory
}
}
}
Expand Down
Loading