Fix issue #383: Optimize SQL queries for notification storm prevention #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eeshu-Yadav
force-pushed
the
issues/383-optimize-notification-sql-queries
branch
from
26f2f30 to
480df32
Compare
…#383 - Implemented bulk notification creation using Django's bulk_create() - Added bulk_check_notification_storm_and_unread_count() function to perform aggregated queries instead of individual COUNT queries per recipient - Added bulk_notification_update_handler() for efficient websocket updates - Reduced SQL queries from 3*N to 1-2 total queries for N recipients - Preserved all existing functionality including email notifications - All tests pass with significant performance improvement Closes openwisp#383
Eeshu-Yadav
force-pushed
the
issues/383-optimize-notification-sql-queries
branch
from
480df32 to
f50f875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Closes #383.
Description of Changes
This PR optimizes SQL queries in the notification system to address performance issues when sending notifications to multiple recipients. The main improvements include:
Performance Optimizations:
bulk_create()instead of individual savesCount()withQ()filters instead of separate COUNT queries per recipientTechnical Changes:
notify_handler()inhandlers.pyto use bulk creation with proper signal managementbulk_check_notification_storm_and_unread_count()function for efficient multi-recipient storm checkingbulk_notification_update_handler()for optimized websocket updates